1 files changed, 11 insertions, 10 deletions

diff --git a/modules/generate.source.sh b/modules/generate.source.sh
index 7066576a..b82b5671 100644
--- a/modules/generate.source.sh
+++ b/modules/generate.source.sh
@@ -15,7 +15,7 @@ generate::make_link () {
     done < <(echo "$line" | tr ' ' '\n')
 
     if grep -E -q "$IMAGE_PATTERN" <<< "$link"; then
-        if [ $what == md ]; then
+        if [ "$what" == md ]; then
             md::make_img "$link" "$descr"
         else
             html::make_img "$link" "$(html::special "$descr")"
@@ -23,7 +23,7 @@ generate::make_link () {
         return
     fi
 
-    if [ $what == md ]; then
+    if [ "$what" == md ]; then
         md::make_link "$link" "$descr"
     else
         html::make_link "$link" "$(html::special "$descr")"
@@ -38,11 +38,11 @@ generate::fromgmi_ () {
     local dest_dir=$(dirname "$dest")
 
     test ! -d "$dest_dir" && mkdir -p "$dest_dir"
-    if [ $format == html ]; then
+    if [ "$format" == html ]; then
         cat header.html.part > "$dest.tmp"
         html::fromgmi < "$src" >> "$dest.tmp"
         cat footer.html.part >> "$dest.tmp"
-    elif [ $format == md ]; then
+    elif [ "$format" == md ]; then
         md::fromgmi < "$src" >> "$dest.tmp"
     fi
 
@@ -61,13 +61,14 @@ generate::fromgmi_add_docs () {
     test "$ADD_GIT" == yes && git add "$dest"
 }
 
-generate::fromgmi_convert_atom () {
+generate::convert_gmi_atom_to_html_atom () {
     local -r format="$1"; shift
+    test "$format" != html && return
 
-    test $format != html && return
     $SED 's|.gmi|.html|g; s|gemini://|https://|g' \
         < $CONTENT_DIR/gemtext/gemfeed/atom.xml \
         > $CONTENT_DIR/html/gemfeed/atom.xml
+
     test "$ADD_GIT" == yes && git add $CONTENT_DIR/html/gemfeed/atom.xml
 }
 
@@ -81,14 +82,14 @@ generate::fromgmi_cleanup () {
 }
 
 generate::fromgmi () {
-    find $CONTENT_DIR/gemtext -type f -name \*.gmi | while read -r src; do
+    find "$CONTENT_DIR/gemtext" -type f -name \*.gmi | while read -r src; do
         for format in "$@"; do
             generate::fromgmi_ "$src" "$format"
         done
     done
 
     # Add non-.gmi files to html dir.
-    find $CONTENT_DIR/gemtext -type f | grep -E -v '(.gmi|atom.xml|.tmp)$' |
+    find "$CONTENT_DIR/gemtext" -type f | grep -E -v '(.gmi|atom.xml|.tmp)$' |
     while read -r src; do
         for format in "$@"; do
             generate::fromgmi_add_docs "$src" "$format"
@@ -97,12 +98,12 @@ generate::fromgmi () {
 
     # Add atom feed for HTML
     for format in "$@"; do
-        generate::fromgmi_convert_atom "$format"
+        generate::convert_gmi_atom_to_html_atom "$format"
     done
 
     # Remove obsolete files from ./html/
     for format in "$@"; do
-        find $CONTENT_DIR/$format -type f | while read -r src; do
+        find "$CONTENT_DIR/$format" -type f | while read -r src; do
             generate::fromgmi_cleanup "$src" "$format"
         done
     done