1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
|
package internal
import (
"fmt"
"sync"
"sync/atomic"
"testing"
"time"
)
func TestCommResolverQueueLookupRespectsWorkerLimit(t *testing.T) {
const workers = 2
const lookups = 6
started := make(chan struct{}, lookups)
release := make(chan struct{})
var wg sync.WaitGroup
wg.Add(lookups)
var running int32
var maxRunning int32
resolver := newCommResolver(nil)
defer resolver.shutdown()
resolver.lookupWorkers = workers
resolver.lookupQueue = make(chan uint32, lookups)
resolver.resolveFn = func(tid uint32) string {
current := atomic.AddInt32(&running, 1)
setMaxInt32(&maxRunning, current)
started <- struct{}{}
<-release
atomic.AddInt32(&running, -1)
wg.Done()
return fmt.Sprintf("comm-%d", tid)
}
for i := 1; i <= lookups; i++ {
resolver.queueLookup(uint32(i))
}
waitForStarts(t, started, workers, 2*time.Second)
select {
case <-started:
t.Fatalf("expected at most %d concurrent lookups", workers)
case <-time.After(75 * time.Millisecond):
}
close(release)
waitForWaitGroup(t, &wg, 2*time.Second)
waitForCondition(t, 2*time.Second, "expected all queued tids to be cached", func() bool {
for i := 1; i <= lookups; i++ {
if _, ok := resolver.cached(uint32(i)); !ok {
return false
}
}
return pendingCount(resolver) == 0
})
if got := atomic.LoadInt32(&maxRunning); got > workers {
t.Fatalf("expected max concurrent lookups <= %d, got %d", workers, got)
}
for i := 1; i <= lookups; i++ {
want := fmt.Sprintf("comm-%d", i)
got, ok := resolver.cached(uint32(i))
if !ok {
t.Fatalf("expected cached comm for tid %d", i)
}
if got != want {
t.Fatalf("expected tid %d comm %q, got %q", i, want, got)
}
}
if pending := pendingCount(resolver); pending != 0 {
t.Fatalf("expected no pending lookups after completion, got %d", pending)
}
}
func TestCommResolverQueueLookupQueueFullClearsPending(t *testing.T) {
started := make(chan struct{}, 1)
release := make(chan struct{})
resolver := newCommResolver(nil)
defer resolver.shutdown()
resolver.lookupWorkers = 1
resolver.lookupQueue = make(chan uint32, 1)
resolver.resolveFn = func(tid uint32) string {
select {
case started <- struct{}{}:
default:
}
<-release
return fmt.Sprintf("comm-%d", tid)
}
const tid1 uint32 = 101
const tid2 uint32 = 102
const tid3 uint32 = 103
resolver.queueLookup(tid1)
waitForStarts(t, started, 1, 2*time.Second)
resolver.queueLookup(tid2)
resolver.queueLookup(tid3)
if !hasPending(resolver, tid1) {
t.Fatalf("expected tid %d to remain pending while worker is blocked", tid1)
}
if !hasPending(resolver, tid2) {
t.Fatalf("expected tid %d to remain pending while queued", tid2)
}
if hasPending(resolver, tid3) {
t.Fatalf("expected tid %d pending flag to be cleared when queue is full", tid3)
}
close(release)
waitForCondition(t, 2*time.Second, "expected first two tids to resolve", func() bool {
_, ok1 := resolver.cached(tid1)
_, ok2 := resolver.cached(tid2)
return ok1 && ok2
})
if _, ok := resolver.cached(tid3); ok {
t.Fatalf("did not expect tid %d to resolve from the dropped queue request", tid3)
}
resolver.queueLookup(tid3)
waitForCondition(t, 2*time.Second, "expected dropped tid to be retried successfully", func() bool {
_, ok := resolver.cached(tid3)
return ok
})
}
func TestCommResolverShutdownStopsWorkersAndPreventsNewLookups(t *testing.T) {
started := make(chan struct{}, 1)
release := make(chan struct{})
resolver := newCommResolver(nil)
resolver.lookupWorkers = 1
resolver.lookupQueue = make(chan uint32, 1)
resolver.resolveFn = func(tid uint32) string {
started <- struct{}{}
<-release
return fmt.Sprintf("comm-%d", tid)
}
const activeTID uint32 = 201
const postShutdownTID uint32 = 202
resolver.queueLookup(activeTID)
waitForStarts(t, started, 1, 2*time.Second)
shutdownDone := make(chan struct{})
go func() {
resolver.shutdown()
close(shutdownDone)
}()
select {
case <-shutdownDone:
t.Fatal("shutdown returned before in-flight lookup completed")
case <-time.After(75 * time.Millisecond):
}
close(release)
select {
case <-shutdownDone:
case <-time.After(2 * time.Second):
t.Fatal("timed out waiting for resolver shutdown")
}
resolver.queueLookup(postShutdownTID)
if hasPending(resolver, postShutdownTID) {
t.Fatalf("expected no pending entry after shutdown for tid %d", postShutdownTID)
}
if _, ok := resolver.cached(postShutdownTID); ok {
t.Fatalf("did not expect tid %d to resolve after shutdown", postShutdownTID)
}
if pending := pendingCount(resolver); pending != 0 {
t.Fatalf("expected no pending lookups after shutdown, got %d", pending)
}
}
func hasPending(r *commResolver, tid uint32) bool {
r.mu.RLock()
defer r.mu.RUnlock()
_, ok := r.pending[tid]
return ok
}
func pendingCount(r *commResolver) int {
r.mu.RLock()
defer r.mu.RUnlock()
return len(r.pending)
}
func setMaxInt32(target *int32, candidate int32) {
for {
current := atomic.LoadInt32(target)
if candidate <= current {
return
}
if atomic.CompareAndSwapInt32(target, current, candidate) {
return
}
}
}
func waitForStarts(t *testing.T, ch <-chan struct{}, count int, timeout time.Duration) {
t.Helper()
timer := time.NewTimer(timeout)
defer timer.Stop()
for i := 0; i < count; i++ {
select {
case <-ch:
case <-timer.C:
t.Fatalf("timed out waiting for %d resolver lookups to start", count)
}
}
}
func waitForWaitGroup(t *testing.T, wg *sync.WaitGroup, timeout time.Duration) {
t.Helper()
done := make(chan struct{})
go func() {
wg.Wait()
close(done)
}()
select {
case <-done:
case <-time.After(timeout):
t.Fatal("timed out waiting for resolver lookups to complete")
}
}
func waitForCondition(t *testing.T, timeout time.Duration, message string, fn func() bool) {
t.Helper()
timer := time.NewTimer(timeout)
ticker := time.NewTicker(10 * time.Millisecond)
defer timer.Stop()
defer ticker.Stop()
for {
if fn() {
return
}
select {
case <-timer.C:
t.Fatal(message)
case <-ticker.C:
}
}
}
|