diff options
| author | Paul Buetow <paul@buetow.org> | 2026-03-23 08:27:18 +0200 |
|---|---|---|
| committer | Paul Buetow <paul@buetow.org> | 2026-03-23 08:27:18 +0200 |
| commit | 3ea11bc5d671d962d01b57fa0fba0bda611025fe (patch) | |
| tree | 4aa8c9d8a380a2a176a0a7302d07452a6996e2ef /integrationtests | |
| parent | 2d03ad0ba42bade8579578d12aecbf9a73d9af07 (diff) | |
fix: code quality improvements across lsp, askcli, appconfig, integrationtests
- lsp/handlers_completion.go: track collectFirstCompletion goroutine in
inflight WaitGroup (goroutine leak fix)
- lsp/transport.go: use %w instead of %v for error wrapping
- askcli/command_list.go: extract handleListWithFilters shared helper;
handleList/handleAll/handleReady are now single-liners
- askcli/command_list.go, urgency.go, dep.go: log ParseTaskExport errors
to stderr instead of returning 1 silently
- appconfig/config_load.go: rename 'any' variable to 'found' to avoid
shadowing the built-in identifier
- llm/provider.go: add explanatory comment for package-level registry
- integrationtests/ask_test.go: add //go:build integration tag; move
repoRoot init from init() to TestMain with diagnostic error message
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Diffstat (limited to 'integrationtests')
| -rw-r--r-- | integrationtests/ask_test.go | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/integrationtests/ask_test.go b/integrationtests/ask_test.go index a762b9d..b0f574f 100644 --- a/integrationtests/ask_test.go +++ b/integrationtests/ask_test.go @@ -1,3 +1,5 @@ +//go:build integration + package integrationtests import ( @@ -17,6 +19,7 @@ import ( "codeberg.org/snonux/hexai/internal/askcli" ) +// repoRoot is set in TestMain before any test runs. var repoRoot string func findRepoRoot() string { @@ -40,10 +43,6 @@ func findRepoRoot() string { return "" } -func init() { - repoRoot = findRepoRoot() -} - func askBinaryPath() string { return filepath.Join(repoRoot, "cmd", "ask", "ask") } @@ -216,7 +215,9 @@ func getTaskInfoRaw(ctx context.Context, uuid string) (string, bool) { } func TestMain(m *testing.M) { + repoRoot = findRepoRoot() if repoRoot == "" { + fmt.Fprintln(os.Stderr, "integration tests: cannot find repo root (go.mod or .git)") os.Exit(1) } // Always rebuild the binary so tests reflect the current source. |
