release: v0.11.0 – context-aware in-editor chat; respect general.context_mode; stabilize env-dependent testsv0.11.0

5 files changed, 195 insertions, 7 deletions

diff --git a/internal/hexaiaction/custom_action_test.go b/internal/hexaiaction/custom_action_test.go
index 71319f4..4808079 100644
--- a/internal/hexaiaction/custom_action_test.go
+++ b/internal/hexaiaction/custom_action_test.go
@@ -20,6 +20,8 @@ func (llmFake2) Name() string         { return "fake" }
 func (llmFake2) DefaultModel() string { return "m" }
 
 func TestActionCustom_UsesEditorPrompt(t *testing.T) {
+	// Isolate from user config that might enable custom menu/TUI.
+	t.Setenv("XDG_CONFIG_HOME", t.TempDir())
 	// Seam: choose custom, fake client, and fake editor
 	oldChoose := chooseActionFn
 	oldNew := newClientFromApp
diff --git a/internal/hexaiaction/run_seam_test.go b/internal/hexaiaction/run_seam_test.go
index bbec858..9aa92bf 100644
--- a/internal/hexaiaction/run_seam_test.go
+++ b/internal/hexaiaction/run_seam_test.go
@@ -18,6 +18,8 @@ func (llmFake) Name() string         { return "fake" }
 func (llmFake) DefaultModel() string { return "model" }
 
 func TestRun_WithSeams_SkipAndRewrite(t *testing.T) {
+	// Isolate from user config to avoid environment-dependent behavior/logging.
+	t.Setenv("XDG_CONFIG_HOME", t.TempDir())
 	// Seam: choose action to Skip first, then Rewrite
 	oldChoose := chooseActionFn
 	oldNew := newClientFromApp
@@ -26,8 +28,9 @@ func TestRun_WithSeams_SkipAndRewrite(t *testing.T) {
 	chooseActionFn = func() (ActionKind, error) { return ActionSkip, nil }
 	newClientFromApp = func(_ appconfig.App) (llm.Client, error) { return llmFake{}, nil }
 	var out bytes.Buffer
+	var errBuf bytes.Buffer
 	in := bytes.NewBufferString("some code")
-	if err := Run(context.Background(), in, &out, &out); err != nil {
+	if err := Run(context.Background(), in, &out, &errBuf); err != nil {
 		t.Fatalf("Run skip: %v", err)
 	}
 	if out.String() != "some code" {
@@ -37,7 +40,7 @@ func TestRun_WithSeams_SkipAndRewrite(t *testing.T) {
 	chooseActionFn = func() (ActionKind, error) { return ActionRewrite, nil }
 	out.Reset()
 	in = bytes.NewBufferString(";upper;\nhello")
-	if err := Run(context.Background(), in, &out, &out); err != nil {
+	if err := Run(context.Background(), in, &out, &errBuf); err != nil {
 		t.Fatalf("Run rewrite: %v", err)
 	}
 	if out.String() == "" {
diff --git a/internal/lsp/chat_context_mode_test.go b/internal/lsp/chat_context_mode_test.go
new file mode 100644
index 0000000..85fa4a9
--- /dev/null
+++ b/internal/lsp/chat_context_mode_test.go
@@ -0,0 +1,157 @@
+package lsp
+
+import (
+	"bytes"
+	"strings"
+	"testing"
+	"time"
+)
+
+// Ensure in-editor chat respects general.context_mode by adding window/full-file context.
+func TestChat_RespectsContextModeWindow(t *testing.T) {
+	s := newTestServer()
+	// Configure window mode with small window
+	s.contextMode = "window"
+	s.windowLines = 2
+	s.maxContextTokens = 2000
+	cap := &captureLLM{}
+	s.llmClient = cap
+	var out bytes.Buffer
+	s.out = &out
+
+	uri := "file:///ctx.go"
+	// Build a small file where the last line triggers chat
+	src := "package main\nline2 context\nwhat?>\n"
+	s.setDocument(uri, src)
+
+	s.detectAndHandleChat(uri)
+	// Wait briefly for async goroutine to call Chat
+	for i := 0; i < 40 && len(cap.msgs) == 0; i++ {
+		time.Sleep(10 * time.Millisecond)
+	}
+	if len(cap.msgs) == 0 {
+		t.Fatalf("expected Chat to be called")
+	}
+	// Expect first system, then an extra context user message, then history ending with prompt
+	if cap.msgs[0].Role != "system" {
+		t.Fatalf("first message should be system, got %q", cap.msgs[0].Role)
+	}
+	if len(cap.msgs) < 3 {
+		t.Fatalf("expected at least 3 messages (system, extra, user prompt), got %d", len(cap.msgs))
+	}
+	extra := cap.msgs[1]
+	if extra.Role != "user" || !strings.HasPrefix(extra.Content, "Additional context:\n") {
+		t.Fatalf("second message should be user extra context, got role=%q content=%q", extra.Role, extra.Content)
+	}
+	if !strings.Contains(extra.Content, "line2 context") {
+		t.Fatalf("extra context should include window text; got %q", extra.Content)
+	}
+	last := cap.msgs[len(cap.msgs)-1]
+	if last.Role != "user" || last.Content != "what?" {
+		t.Fatalf("last message should be current prompt user, got %+v", last)
+	}
+}
+
+func TestChat_ContextModeMinimal_NoExtra(t *testing.T) {
+	s := newTestServer()
+	s.contextMode = "minimal"
+	s.maxContextTokens = 2000
+	cap := &captureLLM{}
+	s.llmClient = cap
+	var out bytes.Buffer
+	s.out = &out
+
+	uri := "file:///ctx2.go"
+	s.setDocument(uri, "package main\nhelp?>\n")
+	s.detectAndHandleChat(uri)
+
+	for i := 0; i < 40 && len(cap.msgs) == 0; i++ {
+		time.Sleep(10 * time.Millisecond)
+	}
+	if len(cap.msgs) != 2 {
+		t.Fatalf("expected exactly 2 messages (system + user prompt), got %d", len(cap.msgs))
+	}
+	if cap.msgs[0].Role != "system" || cap.msgs[1].Role != "user" || cap.msgs[1].Content != "help?" {
+		t.Fatalf("unexpected messages: %+v", cap.msgs)
+	}
+}
+
+func TestChat_ContextModeAlwaysFull_AddsExtra(t *testing.T) {
+	s := newTestServer()
+	s.contextMode = "always-full"
+	s.maxContextTokens = 2000
+	cap := &captureLLM{}
+	s.llmClient = cap
+	var out bytes.Buffer
+	s.out = &out
+
+	uri := "file:///ctx3.go"
+	s.setDocument(uri, "package main\nline2\nhelp?>\n")
+	s.detectAndHandleChat(uri)
+
+	for i := 0; i < 40 && len(cap.msgs) == 0; i++ {
+		time.Sleep(10 * time.Millisecond)
+	}
+	if len(cap.msgs) < 3 {
+		t.Fatalf("expected >=3 messages (system, extra, user prompt), got %d", len(cap.msgs))
+	}
+	if cap.msgs[1].Role != "user" || !strings.HasPrefix(cap.msgs[1].Content, "Additional context:\n") {
+		t.Fatalf("second message should be user extra context, got role=%q content=%q", cap.msgs[1].Role, cap.msgs[1].Content)
+	}
+	if !strings.Contains(cap.msgs[1].Content, "package main") {
+		t.Fatalf("extra context should include full file, got %q", cap.msgs[1].Content)
+	}
+	if last := cap.msgs[len(cap.msgs)-1]; last.Role != "user" || last.Content != "help?" {
+		t.Fatalf("last message should be the current prompt, got %+v", last)
+	}
+}
+
+func TestChat_ContextModeFileOnNewFunc_NoExtraWithoutSignature(t *testing.T) {
+	s := newTestServer()
+	s.contextMode = "file-on-new-func"
+	s.maxContextTokens = 2000
+	cap := &captureLLM{}
+	s.llmClient = cap
+	var out bytes.Buffer
+	s.out = &out
+
+	uri := "file:///ctx4.go"
+	s.setDocument(uri, "package main\nhelp?>\n")
+	s.detectAndHandleChat(uri)
+
+	for i := 0; i < 40 && len(cap.msgs) == 0; i++ {
+		time.Sleep(10 * time.Millisecond)
+	}
+	if len(cap.msgs) != 2 {
+		t.Fatalf("expected exactly 2 messages (system + user prompt), got %d", len(cap.msgs))
+	}
+}
+
+func TestChat_ContextModeFileOnNewFunc_WithSignature_AddsExtra(t *testing.T) {
+	s := newTestServer()
+	s.contextMode = "file-on-new-func"
+	s.maxContextTokens = 2000
+	cap := &captureLLM{}
+	s.llmClient = cap
+	var out bytes.Buffer
+	s.out = &out
+
+	uri := "file:///ctx5.go"
+	// Signature without '{' yet; chat prompt appears before the body, so newFunc=true
+	src := "package main\n\nfunc add(x int) int\nhelp?>\n"
+	s.setDocument(uri, src)
+	s.detectAndHandleChat(uri)
+
+	for i := 0; i < 40 && len(cap.msgs) == 0; i++ {
+		time.Sleep(10 * time.Millisecond)
+	}
+	if len(cap.msgs) < 3 {
+		t.Fatalf("expected >=3 messages (system, extra, user prompt), got %d", len(cap.msgs))
+	}
+	if cap.msgs[1].Role != "user" || !strings.HasPrefix(cap.msgs[1].Content, "Additional context:\n") {
+		t.Fatalf("second message should be user extra context, got role=%q content=%q", cap.msgs[1].Role, cap.msgs[1].Content)
+	}
+	if !strings.Contains(cap.msgs[1].Content, "func add(x int) int") {
+		t.Fatalf("extra context should include full file or signature, got %q", cap.msgs[1].Content)
+	}
+}
diff --git a/internal/lsp/handlers_document.go b/internal/lsp/handlers_document.go
index 14642c7..9a12948 100644
--- a/internal/lsp/handlers_document.go
+++ b/internal/lsp/handlers_document.go
@@ -156,10 +156,9 @@ func (s *Server) detectAndHandleChat(uri string) {
 		go func(prompt string, remove int) {
 			ctx, cancel := context.WithTimeout(context.Background(), 15*time.Second)
 			defer cancel()
-			sys := s.promptChatSystem
-			// Build short conversation history from the document above this line
-			history := s.buildChatHistory(uri, lineIdx, prompt)
-			msgs := append([]llm.Message{{Role: "system", Content: sys}}, history...)
+			// Build messages with history and context_mode aware extras.
+			pos := Position{Line: lineIdx, Character: lastIdx + 1}
+			msgs := s.buildChatMessages(uri, pos, prompt)
 			opts := s.llmRequestOpts()
 			logging.Logf("lsp ", "chat llm=requesting model=%s", s.llmClient.DefaultModel())
 			text, err := s.chatWithStats(ctx, msgs, opts...)
@@ -279,6 +278,33 @@ func stripTrailingTrigger(sx string) string {
 	}
 }
 
+// buildChatMessages assembles the chat request messages using:
+// - system from prompts.chat.system
+// - rolling in-editor history up to current prompt
+// - optional extra context per general.context_mode (window/full-file/new-func)
+func (s *Server) buildChatMessages(uri string, pos Position, prompt string) []llm.Message {
+	// Base system and history
+	sys := s.promptChatSystem
+	// Determine line index for history from position
+	lineIdx := pos.Line
+	history := s.buildChatHistory(uri, lineIdx, prompt)
+	// Start with system
+	msgs := []llm.Message{{Role: "system", Content: sys}}
+	// Optional additional context like completion path (insert before history so last remains the prompt)
+	newFunc := s.isDefiningNewFunction(uri, pos)
+	if extra, has := s.buildAdditionalContext(newFunc, uri, pos); has && strings.TrimSpace(extra) != "" {
+		// Reuse completion's extra header template to avoid duplication
+		header := renderTemplate(s.promptCompExtraHeader, map[string]string{"context": extra})
+		if strings.TrimSpace(header) == "" {
+			header = extra
+		}
+		msgs = append(msgs, llm.Message{Role: "user", Content: header})
+	}
+	// Then add history (which ends with the current prompt)
+	msgs = append(msgs, history...)
+	return msgs
+}
+
 // clientApplyEdit sends a workspace/applyEdit request to the client.
 func (s *Server) clientApplyEdit(label string, edit WorkspaceEdit) {
 	params := ApplyWorkspaceEditParams{Label: label, Edit: edit}
diff --git a/internal/version.go b/internal/version.go
index 3402f04..c0a2b88 100644
--- a/internal/version.go
+++ b/internal/version.go
@@ -1,4 +1,4 @@
 // Summary: Hexai semantic version identifier used by CLI and LSP binaries.
 package internal
 
-const Version = "0.10.1"
+const Version = "0.11.0"