diff options
| -rw-r--r-- | internal/repl/repl.go | 3 | ||||
| -rw-r--r-- | internal/rpn/operations.go | 6 | ||||
| -rw-r--r-- | internal/rpn/operations_test.go | 3 | ||||
| -rw-r--r-- | internal/rpn/rpn_test.go | 8 | ||||
| -rw-r--r-- | internal/rpn/variables_test.go | 24 |
5 files changed, 22 insertions, 22 deletions
diff --git a/internal/repl/repl.go b/internal/repl/repl.go index 4e0bca6..200cf20 100644 --- a/internal/repl/repl.go +++ b/internal/repl/repl.go @@ -220,15 +220,16 @@ func saveHistory(history []string) error { if err != nil { return err } - defer file.Close() writer := bufio.NewWriter(file) for _, entry := range history { if _, err := writer.WriteString(entry + "\n"); err != nil { + _ = file.Close() return err } } if err := writer.Flush(); err != nil { + _ = file.Close() return err } return file.Close() diff --git a/internal/rpn/operations.go b/internal/rpn/operations.go index 4bd1e4b..5d90212 100644 --- a/internal/rpn/operations.go +++ b/internal/rpn/operations.go @@ -365,9 +365,9 @@ func (o *Operations) Swap(stack *Stack) error { top := vals[len(vals)-1] second := vals[len(vals)-2] - // Pop both - stack.Pop() - stack.Pop() + // Pop both (this won't fail because we checked stack.Len() >= 2 above) + _, _ = stack.Pop() + _, _ = stack.Pop() // Push in swapped order stack.Push(top) diff --git a/internal/rpn/operations_test.go b/internal/rpn/operations_test.go index ab6e03b..796a8f0 100644 --- a/internal/rpn/operations_test.go +++ b/internal/rpn/operations_test.go @@ -521,8 +521,7 @@ func TestOperationsClearVariables(t *testing.T) { v := NewVariables() o := NewOperations(v) - v.SetVariable("x", 1.0) - v.SetVariable("y", 2.0) + _, _ = v.SetVariable("x", 1.0), v.SetVariable("y", 2.0) o.ClearVariables() diff --git a/internal/rpn/rpn_test.go b/internal/rpn/rpn_test.go index ef53bd9..4acdb82 100644 --- a/internal/rpn/rpn_test.go +++ b/internal/rpn/rpn_test.go @@ -381,7 +381,7 @@ func TestRPNConcurrency(t *testing.T) { go func(id int) { name := fmt.Sprintf("val%d", id) input := fmt.Sprintf("%s = %d", name, id) - r.ParseAndEvaluate(input) + _, _ = r.ParseAndEvaluate(input) done <- true }(i) } @@ -639,9 +639,9 @@ func TestResultStackMultipleValues(t *testing.T) { t.Run(tt.name, func(t *testing.T) { // Set up variables if needed if tt.name == "multiple values with variables" { - r.ParseAndEvaluate("x = 10") - r.ParseAndEvaluate("y = 20") - r.ParseAndEvaluate("z = 30") + _, _ = r.ParseAndEvaluate("x = 10") + _, _ = r.ParseAndEvaluate("y = 20") + _, _ = r.ParseAndEvaluate("z = 30") } result, err := r.ResultStack(tt.input) diff --git a/internal/rpn/variables_test.go b/internal/rpn/variables_test.go index 9dc5882..277a3ea 100644 --- a/internal/rpn/variables_test.go +++ b/internal/rpn/variables_test.go @@ -49,7 +49,7 @@ func TestSetVariable(t *testing.T) { func TestGetVariable(t *testing.T) { v := NewVariables() - v.SetVariable("test", 100.0) + _ = v.SetVariable("test", 100.0) tests := []struct { name string @@ -76,7 +76,7 @@ func TestGetVariable(t *testing.T) { func TestDeleteVariable(t *testing.T) { v := NewVariables() - v.SetVariable("temp", 50.0) + _ = v.SetVariable("temp", 50.0) // Delete existing variable deleted := v.DeleteVariable("temp") @@ -96,9 +96,9 @@ func TestDeleteVariable(t *testing.T) { func TestListVariables(t *testing.T) { v := NewVariables() - v.SetVariable("z", 3.0) - v.SetVariable("a", 1.0) - v.SetVariable("m", 2.0) + _ = v.SetVariable("z", 3.0) + _ = v.SetVariable("a", 1.0) + _ = v.SetVariable("m", 2.0) infos := v.ListVariables() @@ -117,9 +117,9 @@ func TestListVariables(t *testing.T) { func TestClearVariables(t *testing.T) { v := NewVariables() - v.SetVariable("x", 1.0) - v.SetVariable("y", 2.0) - v.SetVariable("z", 3.0) + _ = v.SetVariable("x", 1.0) + _ = v.SetVariable("y", 2.0) + _ = v.SetVariable("z", 3.0) v.ClearVariables() @@ -136,8 +136,8 @@ func TestClearVariables(t *testing.T) { func TestFormatVariables(t *testing.T) { v := NewVariables() - v.SetVariable("pi", 3.14159) - v.SetVariable("e", 2.71828) + _ = v.SetVariable("pi", 3.14159) + _ = v.SetVariable("e", 2.71828) formatted := v.FormatVariables() @@ -161,7 +161,7 @@ func TestFormatVariablesEmpty(t *testing.T) { func TestHasVariable(t *testing.T) { v := NewVariables() - v.SetVariable("exists", 1.0) + _ = v.SetVariable("exists", 1.0) tests := []struct { name string @@ -205,7 +205,7 @@ func TestVariableConcurrency(t *testing.T) { for i := 0; i < 50; i++ { go func(id int) { name := fmt.Sprintf("var%d", id) - v.SetVariable(name, float64(id)) + _ = v.SetVariable(name, float64(id)) done <- true }(i) } |